Check for UIDs in strings as well on start_timeline
#2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you use an exported variable with a path to a file (let's say a timeline):
@export_file var timeline = ""Godot will automatically use a UID path (something like
uid://d0kqf1bb2ev0instead ofres://timeline.dtl) file to avoid having issues when moving that file in the future. This check in Dialogic is only expecting for the stringres://in the argument, so if you do something likeDialogic.start(timeline)it will fail to run.The fix just adds a check for UID as well.
I suspect there are many other places where this is happening, so it would be good to replace all those instances of checking for "res://" to also check for "uid://"